Changeset 13017

Timestamp:

07/15/2021 07:08:36 PM (4 years ago)

Author:

imath

Message:

Make sure regular users can edit field visibility in wp-admin/extended

As we're very close to 9.0.0-RC1, we're also updating credits to include leahkoerper to the list.

Props leahkoerper

Fixes #8529

Location:

trunk/src

Files:

• bp-core/classes/class-bp-admin.php (modified) (2 diffs)
• bp-members/admin/js/admin.js (modified) (2 diffs)
• bp-xprofile/classes/class-bp-xprofile-user-admin.php (modified) (1 diff)

trunk/src/bp-core/classes/class-bp-admin.php

@@ -762 +762 @@
                         printf(
                             /* translators: 1: heart dashicons. 2: BP Credits screen url. 3: number of BuddyPress contributors to this version. */
-                            _n( 'Built with %1$s by <a href="%2$s">%3$d volunteer</a>.', 'Built with %1$s by <a href="%2$s">%3$d volunteers</a>.', 18, 'buddypress' ),
+                            _n( 'Built with %1$s by <a href="%2$s">%3$d volunteer</a>.', 'Built with %1$s by <a href="%2$s">%3$d volunteers</a>.', 19, 'buddypress' ),
                             '<span class="dashicons dashicons-heart"></span>',
                             esc_url( bp_get_admin_url( 'admin.php?page=bp-credits' ) ),
-                            number_format_i18n( 18 )
+                            number_format_i18n( 19 )
                         );
                         ?>
@@ -949 +949 @@
                 <a href="https://profiles.wordpress.org/dcavins/">David Cavins (dcavins)</a>,
                 <a href="https://profiles.wordpress.org/johnjamesjacoby/">John James Jacoby (johnjamesjacoby)</a>,
+                <a href="https://profiles.wordpress.org/leahkoerper/">leahkoerper</a>,
                 <a href="https://profiles.wordpress.org/imath/">Mathieu Viet (imath)</a>,
                 <a href="https://profiles.wordpress.org/modemlooper/">modemlooper</a>,

trunk/src/bp-members/admin/js/admin.js

@@ -3 +3 @@
 ( function( $ ) {
     // Profile Visibility Settings
-
     $( '.visibility-toggle-link' ).on( 'click', function( event ) {
         event.preventDefault();
 
         $( this ).attr( 'aria-expanded', 'true' ).parent().hide()
-            .siblings( '.field-visibility-settings' ).show();
+                 .siblings( '.field-visibility-settings' ).show();
     } );
 
@@ -14 +13 @@
         event.preventDefault();
 
-         $( '.visibility-toggle-link' ).attr( 'aria-expanded', 'false' );
+        $( '.visibility-toggle-link' ).attr( 'aria-expanded', 'false' );
 
-        var settings_div = $(this).parent(),
-        vis_setting_text = settings_div.find( 'input:checked' ).parent().text();
+        var settings_div = $( this ).parent(),
+            vis_setting_text = settings_div.find( 'input:checked' ).parent().text();
 
         settings_div.hide()
-            .siblings( '.field-visibility-settings-toggle' )
-                .children( '.current-visibility-level' ).text( vis_setting_text ).end()
-            .show();
+                    .siblings( '.field-visibility-settings-toggle' )
+                    .find( '.current-visibility-level' ).text( vis_setting_text ).end()
+                    .show();
     } );
 

trunk/src/bp-xprofile/classes/class-bp-xprofile-user-admin.php

@@ -272 +272 @@
 
         $r = bp_parse_args( $args['args'], array(
-            'profile_group_id' => 0,
-            'user_id'          => $user->ID,
-            'hide_field_types' => array( 'wp-textbox', 'wp-biography' ),
+            'profile_group_id'       => 0,
+            'user_id'                => $user->ID,
+            'hide_field_types'       => array( 'wp-textbox', 'wp-biography' ),
+            'fetch_visibility_level' => bp_current_user_can( 'bp_moderate' ) || (int) $user->ID === (int) get_current_user_id(),
         ), 'bp_xprofile_user_admin_profile_loop_args' );