Ensure that scripts don't swallow errors

Author: dabrahams

scripts/carthage.sh

@@ -1,14 +1,14 @@
-#!/usr/bin/env bash
+#!/usr/bin/env bash -e -o pipefail
 #
 # Needed to circumvent an issue with Carthage version < 0.37.0: https://.com/Carthage/Carthage/issues/3019
 #
 # carthage.sh
 # Usage example: ./carthage.sh build --platform iOS
 
 VERSION="$(carthage version)"
-"$(dirname "$0")/versions.sh" "$VERSION" "0.37.0"
+comparison=$("$(dirname "$0")/versions.sh" "$VERSION" "0.37.0"; echo $?)
 
-if [ $? -ge 0 ]; then
+if [ $comparison -ge 0 ]; then
 # Carthage version is greater than or equal to 0.37.0 meaning we can use the --use-xcframeworks flag
 carthage "$@" --use-xcframeworks
 else

scripts/findproject.sh

@@ -1,4 +1,4 @@
-#!/usr/bin/env bash
+#!/usr/bin/env bash -e -o pipefail
 #
 # xcframework.sh
 # Usage example: ./findproject.sh --project-name <project_name>

scripts/printformat.sh

@@ -1,4 +1,4 @@
-#!/usr/bin/env bash
+#!/usr/bin/env bash -e -o pipefail
 #
 # https://gist..com/SomeRandomiOSDev/798406a4a15f6b5d78b010599865c04f
 #

scripts/resolvepath.sh

@@ -1,4 +1,4 @@
-#!/usr/bin/env bash
+#!/usr/bin/env bash -e -o pipefail
 #
 # resolvepath.sh
 # Usage example: ./resolvepath.sh "./some/random/path/../../"

scripts/versions.sh

@@ -1,4 +1,4 @@
-#!/usr/bin/env bash
+#!/usr/bin/env bash -e -o pipefail
 #
 # versions.sh
 # Usage example: ./versions.sh "1.4.15" "1.7.0"

scripts/workflowtests.sh

@@ -1,4 +1,4 @@
-#!/usr/bin/env bash
+#!/usr/bin/env bash -e -o pipefail
 #
 # workflowtests.sh
 # Usage example: ./workflowtests.sh --no-clean
@@ -261,9 +261,9 @@ if which carthage >/dev/null; then
 CARTHAGE_VERSION="$(carthage version)"
 echo "Carthage: $CARTHAGE_VERSION"
 
-"$SCRIPTS_DIR/versions.sh" "$CARTHAGE_VERSION" "0.37.0"
+comparison=$("$SCRIPTS_DIR/versions.sh" "$CARTHAGE_VERSION" "0.37.0"; echo $?)
 
-if [ $? -lt 0 ]; then
+if [ $comparison -lt 0 ]; then
 "$SCRIPTS_DIR/printformat.sh" "foreground:yellow" "Carthage version of at least 0.37.0 is recommended for running these unit tests"
 fi
 else
@@ -274,9 +274,9 @@ fi
 
 if which pod >/dev/null; then
 PODS_VERSION="$(pod --version)"
-"$SCRIPTS_DIR/versions.sh" "$PODS_VERSION" "1.7.3"
+comparison=$("$SCRIPTS_DIR/versions.sh" "$PODS_VERSION" "1.7.3"; echo $?)
 
-if [ $? -ge 0 ]; then
+if [ $comparison -ge 0 ]; then
 echo "CocoaPods: $PODS_VERSION"
 else
 checkresult -1 "These unit tests require version 1.7.3 or later of CocoaPods: $("$SCRIPTS_DIR/printformat.sh" "foreground:blue;underline" "https://guides.cocoapods.org/using/getting-started.html#updating-cocoapods")"

scripts/xcframework.sh

@@ -1,4 +1,4 @@
-#!/usr/bin/env bash
+#!/usr/bin/env bash -e -o pipefail
 #
 # xcframework.sh
 # Usage example: ./xcframework.sh --output <some_path>/<name>.xcframework