Restore browserify support (fix #128) #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Using jsonld in a browserify-based build script does not works any more. This PR update the `browser` key in `package.json` in order force browserify to use the `dist` version for the browser (generated by webpack during release process). This solution provide browserify support without the needs to maintain complex configuration for both webpack and browserify. It could be less optimal in term of bundle size (for browserify use a bundled version of jsonld), but that is better than nothing and the modern minification tools may resolve this kind of optimization.
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Using jsonld in a browserify-based build script does not works any more.
This PR update the
browserkey inpackage.jsonin order forcebrowserify to use the
distversion for the browser (generated bywebpack during release process).
This solution provide browserify support without the needs to maintain
complex configuration for both webpack and browserify.
It could be less optimal in term of bundle size (for browserify use a
bundled version of jsonld), but that is better than nothing and the
modern minification tools may resolve this kind of optimization needs.