Skip to content

chore: update display-notification to v3 #47

New issue

Have a question about this project? Sign up for a free account to open an issue and contact its maintainers and the community.

By clicking “Sign up for ”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on ? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikejancar
Copy link

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

Changes made

  • Updates the version of display-notification from 2.0.0 to 3.0.0
  • Updates the module's require statement to be dynamic to align with the new version of display-notification

Reason for the change

Some security scanners list the 0.10.0 version of the execa package as being vulnerable to a command injection attack. The execa package is a direct dependency of the run-applescript package which is a direct dependency of display-notification. This update upgrades run-applescript to a ^5.0.0 version which takes execa up to a ^5.0.0 version.

@socket-securitySocket Security
Copy link

New, updated, and removed dependencies detected. Learn more about Socket for ↗︎

PackageNew capabilitiesTransitivesSizePublisher
npm/[email protected] 🔁 npm/[email protected]Transitive: environment, filesystem, shell+12131 kBsindresorhus

View full report↗︎

@mikejancar
Copy link
Author

Is there anything else that is needed before this PR can be reviewed? I believe that I have followed all of the guidelines, but I may have missed something.

@jason-easterday
Copy link

Looks pretty straight forward to me.

@tcozzens
Copy link

cc: @titanism @niftylettuce I think this is ready!

Sign up for free to join this conversation on . Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants