Added Langchain Embedding Plugin #1045
Conversation
📌 Cov diff with main: 📌 Overall coverage: |
In the PR description is demoed import from langchain community. I guess it should be import form ADS? |
| return decorator | ||
| class OCIModelDeploymentEndpointEmbeddings(BaseModel, Embeddings): |
There was a problem hiding this comment.
Maybe we can use OCIDataScienceEmbedding name instead?
| max_retries: int = 1 | ||
| """The maximum number of retries to make when generating.""" | ||
| @root_validator() |
There was a problem hiding this comment.
I guess we don't need this logic?
ads/llm/langchain/plugins/embeddings/oci_data_science_model_deployment_endpoint.py Show resolved Hide resolved
| .. code-block:: python3 | ||
| from langchain_community.embeddings import OCIModelDeploymentEndpointEmbeddings |
There was a problem hiding this comment.
I guess till we don't have it in langchain repo, it would be better to import from ads?
📌 Cov diff with main: 📌 Overall coverage: |
📌 Cov diff with main: 📌 Overall coverage: |
| import requests | ||
| from langchain_core.embeddings import Embeddings | ||
| from langchain_core.language_models.llms import create_base_retry_decorator | ||
| from langchain_core.pydantic_v1 import BaseModel, Field |
There was a problem hiding this comment.
Using langchain_core.pydantic_v1 will cause conflicts with newer versions of langchain and pydantic v2.
See: https://python.langchain.com/docs/versions/v0_3/#1-do-not-use-the-langchain_corepydantic_v1-namespace
Please test using from pydantic import BaseModel, Field
There was a problem hiding this comment.
I tried it in the previous commit but it got the error too. Let me reproduce this again.
…b.com/oracle/accelerated-data-science into ODSC-64498/langchain_embedding_plugin
625c12d 📌 Cov diff with main: 📌 Overall coverage: |
📌 Cov diff with main: 📌 Overall coverage: |
…b.com/oracle/accelerated-data-science into ODSC-64498/langchain_embedding_plugin
📌 Cov diff with main: 📌 Overall coverage: |
📌 Cov diff with main: 📌 Overall coverage: |
📌 Cov diff with main: 📌 Overall coverage: |
📌 Cov diff with main: 📌 Overall coverage: |
…b.com/oracle/accelerated-data-science into ODSC-64498/langchain_embedding_plugin
fd7b7be 📌 Cov diff with main: 📌 Overall coverage: |
📌 Cov diff with main: 📌 Overall coverage: |
📌 Cov diff with main: 📌 Overall coverage: |
📌 Cov diff with main: 📌 Overall coverage: |
Added Langchain Embedding Plugin