Switch cache delete default mechanism #1050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
📌 Cov diff with main: 📌 Overall coverage: |
mrDzurb previously approved these changes Jan 31, 2025
mayoor approved these changes Feb 1, 2025
a11f503 to 5e2e4f4 Compare mayoor previously approved these changes Feb 1, 2025
📌 Cov diff with main: 📌 Overall coverage: |
📌 Cov diff with main: 📌 Overall coverage: |
…e/accelerated-data-science into switch_cache_delete_default_option
📌 Cov diff with main: 📌 Overall coverage: |
ahosler approved these changes Feb 3, 2025
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up on the PR#1044 to delete cache folder from the local directly in a notebook session.
For cache delete option, we want the user to set this flag explicitly when using CLI to register models. Deleting without any user input may result in bad experience for the user, in case they would like to keep the artifacts for further use.
In the UI, we'll have a checkbox that will always be selected by default for deleting cache, but user may uncheck it if needed. User will be able to see that the cache will be deleted, so they can choose to opt out of cache deletion if needed.