Skip to content

Keep default padding on nested sub-menus #62749

New issue

Have a question about this project? Sign up for a free account to open an issue and contact its maintainers and the community.

By clicking “Sign up for ”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on ? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

graylaurenm
Copy link
Contributor

What?

Modifies the selector that manages submenu padding.

Why?

Nested submenus are missing necessary padding to visually align with other menu items.

How?

Changes the selector to only target top-level submenus.

Testing Instructions

Create a navigation block:
Level 1

  • Level 2 (A)
    • Level 3
  • Level 2 (B)

Notice how "Level 2 (A)" has no padding-left while "Level 2 (B)" does.

Testing Instructions for Keyboard

N/A

Screenshots or screencast

Before:
Screenshot 2024-06-21 at 9 24 29 AM

After:
Screenshot 2024-06-21 at 9 24 15 AM

@github-actionsGitHub Actions
Copy link

-actions bot commented Jun 21, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical , [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: [Package] Block library, First-time Contributor.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actionsGitHub Actions
Copy link

-actions bot commented Jun 21, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on , copy and paste the following into the bottom of the merge commit message.

Co-authored-by: graylaurenm <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actionsGitHub Actions
Copy link

-actions bot commented Jun 21, 2024

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @graylaurenm! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions-actions bot added the First-time ContributorPull request opened by a first-time contributor to Gutenberg repositorylabel Jun 21, 2024
@akasunilakasunil added the [Package] Block library/packages/block-librarylabel Jun 23, 2024
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Labels
First-time ContributorPull request opened by a first-time contributor to Gutenberg repository[Package] Block library/packages/block-library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants