Skip to content

Add Custom Transition Settings to theme.json #62972

New issue

Have a question about this project? Sign up for a free account to open an issue and contact its maintainers and the community.

By clicking “Sign up for ”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on ? Sign in to your account

Closed

Conversation

geekofshire
Copy link

Summary

This PR adds custom settings for CSS transitions in the theme.json file. The new settings include transition durations, timing functions, and delays, each with detailed descriptions, types, and default values.

Changes

  • Added transition object under settings.custom in theme.json.
  • Defined properties for duration, timing, and delay with metadata.
  • Enhanced documentation within theme.json for better understanding and maintenance.

Impact

These changes allow themes to define default CSS transitions, providing a consistent and customizable user experience across blocks and patterns.

Related Issue - #62885

@github-actionsGitHub Actions
Copy link

-actions bot commented Jun 28, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their and WordPress.org accounts: @[email protected].

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on , copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: [email protected].


To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actionsGitHub Actions
Copy link

-actions bot commented Jun 28, 2024

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @geekofshire! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions-actions bot added the First-time ContributorPull request opened by a first-time contributor to Gutenberg repositorylabel Jun 28, 2024
@github-actionsGitHub Actions
Copy link

-actions bot commented Jun 28, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical , [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: First-time Contributor, [Feature] Themes.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@geekofshiregeekofshire changed the title Add Custom Transition Settings to theme.json with Descriptions and Default Values Add Custom Transition Settings to theme.json Jun 28, 2024
@t-hamanot-hamano self-requested a review June 29, 2024 01:57
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

You probably submitted this PR after seeing my comment.

However, the code I proposed is not intended to be incorporated as the default into WordPress core/Gutenberg, but merely defined an example of adding custom properties as needed to each theme.

Since the CSS properties we want to add vary depending on the theme, it would be difficult to incorporate hard-coded values ​​as defaults.

Therefore, I will close this PR, but please feel free to comment if there is anything I have missed.

@t-hamanot-hamano added the [Feature] ThemesQuestions or issues with incorporating or styling blocks in a theme.label Jun 29, 2024
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Labels
[Feature] ThemesQuestions or issues with incorporating or styling blocks in a theme.First-time ContributorPull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants