Skip to content

Storybook: Fix warnings in Layout document #67865

New issue

Have a question about this project? Sign up for a free account to open an issue and contact its maintainers and the community.

By clicking “Sign up for ”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on ? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Dec 12, 2024

What?

Fixing a warning and an error in the Foundations: Layout document in Storybook.

Why?

To keeping code high quality and prevent unnecessary warnings and errors.

Found while working on #67863.

How?

We're importing from @storybook/blocks and adding a tbody wrapper.

Testing Instructions

Testing Instructions for Keyboard

Same

Screenshots or screencast

Screenshot 2024-12-12 at 11 44 43

@tyxlatyxla added [Type] EnhancementA suggestion for improvement.StorybookStorybook and its stories for componentslabels Dec 12, 2024
@tyxlatyxla requested review from jameskoster and a team December 12, 2024 09:45
@tyxlatyxla self-assigned this Dec 12, 2024
@github-actionsGitHub Actions
Copy link

-actions bot commented Dec 12, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on , copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tyxla <[email protected]>
Co-authored-by: jameskoster <[email protected]>
Co-authored-by: mirka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tyxlatyxla merged commit aca8187 into trunk Dec 13, 2024
71 checks passed
@tyxlatyxla deleted the fix/ds-foundations-layout-warnings branch December 13, 2024 07:03
@github-actions-actions bot added this to the Gutenberg 20.0 milestone Dec 13, 2024
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
Co-authored-by: tyxla <[email protected]>
Co-authored-by: jameskoster <[email protected]>
Co-authored-by: mirka <[email protected]>
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
Co-authored-by: tyxla <[email protected]>
Co-authored-by: jameskoster <[email protected]>
Co-authored-by: mirka <[email protected]>
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Labels
StorybookStorybook and its stories for components[Type] EnhancementA suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants