Site Editor: Fix obsolete getLocationWithParams usage #68388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This was referencedDec 30, 2024
Size Change: -4 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
Flaky tests detected in 4bb1d08. 🔍 Workflow run URL: https://.com/WordPress/gutenberg/actions/runs/12545991771
|
ramonjd approved these changes Dec 30, 2024
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their and WordPress.org accounts: @JungleGenius. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on , copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
I think Gutenberg 20 has been delayed a week, but an RC will be cut this week (?) If that's not the case, maybe worth a point release? |
JungleGenius commented Dec 31, 2024
Hi Folks @ramonjd @tyxla @himanshupathak95, Thanks you for the swift response and bug fix. I was trying to get a landing/order page up over the Holliday when I ran headlong into this bug. I am really impressed with your team's actions once I got the bug got on your radar. (The front line Wordpress.COM user support was lacking, but it look like the dev team is really on the ball response wise). Normally I would just create a pull request for the bug fix like I did for the Groundhog plug-in over here, but I'm not currently setup for WordPress core development (I mostly do Laravel and CodeIgniter). The theme/plug-in editor won't let me view or debug the core files so I was kind of stuck. I ended up pasting the JSON into the pages manually to work around this, but it was buggy because the block editor needs to "resolve" the pasted json code. I think you are going to need a dot release to get this into Wordpress.COM in the short term. Thanks everyone. Great work. -Daniel |
Thank you @JungleGenius! Once a new version of Gutenberg is released (which I believe should be in a week from now), folks have historically tried to quickly release it to WP.com, at which point the fix should be in place there. |
Gulamdastgir-Momin pushed a commit to Gulamdastgir-Momin/gutenberg that referenced this pull request Jan 23, 2025
) Unlinked contributors: JungleGenius. Co-authored-by: tyxla <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: himanshupathak95 <[email protected]>
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What?
Fixing two instances of
history.getLocationWithParams()that were causing errors.Reported in #67199 (comment) and #68367.
Fixes #68367.
Why?
In #67199 we got rid of
useHistory()'sgetLocationWithParams()method. However, we forgot to update a couple of instances.How?
We're using
useLocation()to retrieve query arguments.Testing Instructions
Testing Instructions for Keyboard
Same
Screenshots or screencast
The error that was appearing in the snackbar notice:
