Skip to content
This repository was archived by the owner on Jan 26, 2022. It is now read-only.

Having an h1 on single posts #249

Merged
merged 3 commits into from
Dec 7, 2021
Merged

Having an h1 on single posts #249

merged 3 commits into from
Dec 7, 2021

Conversation

SGr33n
Copy link
Contributor

@SGr33n SGr33n commented Nov 18, 2021

The single.html template doesn't have an h1 that should be the post title.

The single.html template doesn't have an h1 that should be the post title.
@SGr33nSGr33n changed the title Having an H1 on single post. Having an h1 on single posts Nov 18, 2021
@kjellrkjellr mentioned this pull request Nov 18, 2021
@kjellrkjellr changed the title Having an h1 on single posts Having an h1 on single posts and pages Nov 18, 2021
@kjellrkjellr changed the title Having an h1 on single posts and pages Having an h1 on single posts Nov 18, 2021
@kjellr
Copy link
Collaborator

kjellr commented Nov 18, 2021

Since the Site Title is a H1, implementing this (or #250) would unfortunately break compliance with the accessibility guidelines for themes. Let's continue to discuss in #233.

@kjellr
Copy link
Collaborator

As per the discussion in #233 (comment), we should be ok using more than one H1 per page. I've updated the "No Separators" template too, and will merge this in. Thanks for the help, @SGr33n!

@kjellrkjellr merged commit ad51ce5 into WordPress:trunk Dec 7, 2021
Sign up for free to subscribe to this conversation on . Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants