Skip to content

Gutenberg Shortcode-based Blocks Fix #3403 #30

New issue

Have a question about this project? Sign up for a free account to open an issue and contact its maintainers and the community.

By clicking “Sign up for ”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on ? Sign in to your account

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

SirLouen
Copy link

Trac Issue:
https://bbpress.trac.wordpress.org/ticket/3403

Original PR #4

Props to @georgestephanis and @adamsilverstein for the original code and review of the code, respectively.

I hope this time we can close this PR 👍

@SirLouenSirLouen changed the title Guteberg Shortcode-based Blocks Fix #3403 Gutenberg Shortcode-based Blocks Fix #3403 Nov 13, 2024
@webmandesign
Copy link

Hi @SirLouen,

I can see your PR is adding blocks to bbPress.

I haven't tested this PR on a website, just checked your code, so take this feedback with a grain of salt.

I think the blocks will not resolve all bbPress views. I'm not sure if a view such as editing/splitting/merging Forum/Topic/Reply would work with these blocks?

To resolve these I've created Enable bbPress for Block Themes plugin (still waiting for a review at WPORG), which:

  1. Adds support for block templates in themes with simple code. This alone displays all bbPress content correctly using theme's page.html template (or other templates if they are available in the theme).
  2. Registers a new "bbPress content" block template that serves as bbPress content renderer. I introduced this template so the page.html can be used separately.

In addition to these, user can optionally enable block editor support for bbPress post types (I can see your PR does that too), then create single/archive templates for these post types in Site Editor, and then disable the block editor support (so it is not allowed to use blocks in Forum/Topic/Reply content), while still keeping those custom templates.

Maybe @JJJ could provide feedback whether both approaches could be integrated in bbPress?

Sign up for free to join this conversation on . Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants