Memory fixes and proper killing of processes #214
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I managed to fix some of the common issues on my fork, ing Context and non working kill command to be specific.
Steps to install if this doesn't get merged:
build.gradle
dependencies.compile 'com..diegoperini:ffmpeg-android-java:v0.4.6'
Link for the fork: https://.com/diegoperini/ffmpeg-android-java
Changelog:
whenFFmpegIsReady()
to properly wait for ffmpeg state.killRunningProcesses()
to properly kill the execution.FFmpeg.getInstance()
overload to work with aContextProvider
instead of a context. It is a fix for a common memory caused by storing the context internally. Old factory method is still supported but marked as deprecated.