- Notifications
You must be signed in to change notification settings - Fork 48
Added API to get multi model deployment config #1055
New issue
Have a question about this project? Sign up for a free account to open an issue and contact its maintainers and the community.
By clicking “Sign up for ”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on ? Sign in to your account
Added API to get multi model deployment config #1055
Conversation
…ence into ODSC-68152/list_compatible_shapes
tests/unitary/with_extras/aqua/test_data/deployment/aqua_multi_model_deployment_config.json Show resolved Hide resolved
Hi @lu-ohai, can you add more description into the PR? Also add the test and validation details. Share what is the expected input data and what would be the output, just provide a couple of use cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall, the get_multimodel_compatible_shapes API might be a very slow operation given that we have to get the config file from object storage for each model. On average, the get_deployment_config API call takes 4-6 seconds for each model. It could result in a bad experience if user select 2-3 models and waits for 10-15 seconds only to see a message saying the combination is not feasible. We can probably cache the result for each model so that the subsequent calls are faster. Or we can send parallel async requests to fetch multiple configs, instead of reading them sequentially. Some testing will be required to confirm what optimizations may be required.
cc: @mrDzurb
Totally agree. We should use both technics caching and threadpool. 4-6 seconds to read a file from OS bucket, this is insane :) |
@mrDzurb @VipulMascarenhas Based on the testing, fetching configs from three model ids takes roughly 5-6 microseconds, so wondering under which case it takes |
…racle/accelerated-data-science into ODSC-68152/list_compatible_shapes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
0f08a64
into feature/multi_model_deployment
Added API to get multi model deployment config
Input/Output format
Notebook
jwsq
) and it gets the maximum gpu count.