Adding defined metadata to fine-tuned model #1164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mrDzurb approved these changes Apr 23, 2025
| @@ -315,6 +316,23 @@ def create( | |||
| model_by_reference=True, | |||
| defined_tags=create_fine_tuning_details.defined_tags, | |||
| ) | |||
| defined_metadata_dict = {} | |||
There was a problem hiding this comment.
Could you add a comment here about why do we need this?
There was a problem hiding this comment.
Sure.defined_metadata_dict is a dict of key value pair where key is the defined metadata key and value is the artifact content. Since here , we are copying the defined metadata (for which artifact exists) from service to user tenancy ,there is no direct way to copy. So we have to fetch the content of the metadata artifact from service tenancy and create new key value pairs in user tenancy.
This way while fetching config for fine-tuned model , request won't go to service tenancy bucket.
📌 Cov diff with main: 📌 Overall coverage: |
VipulMascarenhas approved these changes Apr 23, 2025
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
For fine-tuned model , we need to update defined metadata to include Deployment Configuration , Readme , and License so that the call to fetch these config doesn't go to service tenancy bucket (for cached model).
Unit tests