add fish snippets from bmalehorn/vscode-fish

[remche]

This PR add fish snippets from bmalehorn/vscode-fish

Thanks form maintaining this repo !

[OkelleyDevelopment]

Thanks for the PR, just a few things to revise and then we'll be golden 😎

[OkelleyDevelopment]

The else snippet can probably be omitted since the if and if else are already defined here

[OkelleyDevelopment]

these snippets should also be removed in favor of just having someone leverage the first function snippet.

[OkelleyDevelopment]

Please take this comment to apply to the if and while snippet variants too.

[remche]

Note sure what you mean here (not very familiar with snippet development). How to leverage the multiple possibility with only one snippet ?

[OkelleyDevelopment]

Hi @remche, sorry for the delay.

What I had meant earlier, was someone can just use the function definition for all of these cases (no arguments, arguments, etc) if we modify the body like so:

    "body": [
      "function ${1:name} $0",
      "end"
    ]
  }

Then we don't clutter the snippets and the user's cursor will end on the first line allowing for them to specify arguments OR enter and tab to define the function body.

This same approach can be done for the if, else snippets added above too.

[OkelleyDevelopment]

Hi @remche, sorry for the delay.

What I had meant earlier, was someone can just use the function definition for all of these cases (no arguments, arguments, etc) if we modify the body like so:

    "body": [
      "function ${1:name} $0",
      "end"
    ]
  }

Then we don't clutter the snippets and the user's cursor will end on the first line allowing for them to specify arguments OR enter and tab to define the function body.

This same approach can be done for the if, else snippets added above too.