update allowances for image with empty alt #243
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
commit to remove allowance for
role=presentation
androle=none
on an<img src=... alt="">
. Declaring these roles should be considered redundant/unnecessary per thealt=""
.If there are situations where an image with
alt=""
is not being set to decorative, (thinking an img with a .svg source in webkit) then authors can still usearia-hidden=true
to force the element to be hidden to the a11y tree (and would have needed to use that anyway).closes #229
Preview | Diff