Update pywebsocket to latest master #45346
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Updates tools/third_party/pywebsocket3 to its main branch HEAD, via: git subtree pull --prefix tools/third_party/pywebsocket3 https://.com/GoogleChromeLabs/pywebsocket3 master --squash
git-subtree-dir: tools/wptserve/third_party/pywebsocket3 git-subtree-split: 3a1011f8ac40c9df81cec39563c93addb8d9436e
whimboo reviewed Apr 2, 2024
| import os | ||
| here = os.path.dirname(__file__) | ||
| PACKAGE_VERSION = '4.0.1' |
There was a problem hiding this comment.
@jgraham I assume that you will bump and release in a follow-up PR or can we combine the release here as well?
There was a problem hiding this comment.
This file has shebang but is not executable. Can we remove that?
I see some test files (e.g. https://.com/web-platform-tests/wpt/blob/master/websockets/handlers/echo_wsh.py) are still referencing I tried to roll the change to chromium, and run the change on our CI. It reported some websocket tests are failing. |
@jgraham GoogleChromeLabs/pywebsocket3#30 is fixed now, if you want to use pypi instead. |
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We don't seem to be able to get a new release, and pywebsocket bugs are currently blocking Python 3.12 support