Skip to content

chore: update display-notification to v3 #47

New issue

Have a question about this project? Sign up for a free account to open an issue and contact its maintainers and the community.

Sign up for

By clicking “Sign up for ”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on ? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: update display-notification to v3 #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ const path = require('path');
const process = require('process');
const util = require('util');
const { Buffer } = require('buffer');
const displayNotification = require('display-notification');
const getPort = require('get-port');
const nodemailer = require('nodemailer');
const open = require('open');
Expand DownExpand Up@@ -89,6 +88,7 @@ const previewEmail = async (message, options) => {
// `xcrun simctl openurl booted ${url}`
//
if (isMacOS && !isCI && options.openSimulator) {
const { displayNotification } = await import('display-notification');
try {
// <https://.com/sindresorhus/open/blob/05ba9e150cc1a2629e518a9cc19b586c6ca3f269/index.js#L205-L222>
const simulator = childProcess.spawn('open', ['-a', 'Simulator']);
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@
],
"dependencies": {
"ci-info": "^3.8.0",
"display-notification": "2.0.0",
"display-notification": "^3.0.0",
"fixpack": "^4.0.0",
"get-port": "5.1.1",
"mailparser": "^3.7.1",
Expand Down